Rename a few bindings with a proper descriptive naming#234
Merged
Conversation
brnrdog
force-pushed
the
brnrdog/descriptive-make-fns
branch
from
8375600 to
19fd915
Compare
brnrdog
changed the title
brnrdog
commented
Apr 17, 2026
Comment on lines
-81
to
-106
| /** | ||
| [Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/roundRect) | ||
| */ | ||
| @send | ||
| external roundRect2: ( | ||
| path2D, | ||
| ~x: float, | ||
| ~y: float, | ||
| ~w: float, | ||
| ~h: float, | ||
| ~radii_: array<float>=?, | ||
| ) => unit = "roundRect" | ||
|
|
||
| /** | ||
| [Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/roundRect) | ||
| */ | ||
| @send | ||
| external roundRect3: ( | ||
| path2D, | ||
| ~x: float, | ||
| ~y: float, | ||
| ~w: float, | ||
| ~h: float, | ||
| ~radii_: array<float>=?, | ||
| ) => unit = "roundRect" | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
These were repeated, same signature as roundRect
brnrdog
commented
Apr 17, 2026
Comment on lines
-783
to
-809
| [Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/roundRect) | ||
| */ | ||
| @send | ||
| external roundRect2: ( | ||
| canvasRenderingContext2D, | ||
| ~x: float, | ||
| ~y: float, | ||
| ~w: float, | ||
| ~h: float, | ||
| ~radii_: array<float>=?, | ||
| ) => unit = "roundRect" | ||
|
|
||
| /** | ||
| [Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/roundRect) | ||
| */ | ||
| @send | ||
| external roundRect3: ( | ||
| canvasRenderingContext2D, | ||
| ~x: float, | ||
| ~y: float, | ||
| ~w: float, | ||
| ~h: float, | ||
| ~radii_: array<float>=?, | ||
| ) => unit = "roundRect" | ||
|
|
||
| /** | ||
| [Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/arc) |
Collaborator
Author
There was a problem hiding this comment.
These were repeated as well
35 tasks
Collaborator
|
This looks good! We should update the target branch to |
brnrdog
changed the base branch from
vlk/remove-api-from-module-names
to
pre-alpha
brnrdog
force-pushed
the
brnrdog/descriptive-make-fns
branch
from
68817cd to
252361a
Compare
Collaborator
Author
|
@jderochervlk updated the pull request's target and rebased |
Get read of ambiguous bindings names such as make2, make3, createPattern3, drawFocusIfNeeded2, etc
brnrdog
force-pushed
the
brnrdog/descriptive-make-fns
branch
from
252361a to
edeb2c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a few constructor bindings lacking good naming.
For example, VideoFrame has about 10 bindings for the same function targeting different signatures, and we were using
make2,make3,make4and to define those bindings.This pull request renames these bindings with better names based on their arguments.
These are breaking changes.