Address review feedback: rename constructors, unbox FormDataEntryValue, reuse MessageEvent types, simplify tests#253
Merged
jderochervlk merged 1 commit intocarryover/post-249-pre-alphafrom Apr 19, 2026
Conversation
Drop scroll2/scrollTo2/scrollBy2 and keep the descriptive *XY overload names requested in review. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MediaStream.MessageEvent.FormDataentry values for ergonomics.Description
MediaStreamoverloaded constructors inpackages/MediaCaptureAndStreams/src/MediaStream.resfrommake2/make3tomakeFromMediaStream/makeFromMediaStreamsfor clarity.Types.formDataEntryValuewith a local@unboxedvariant API inpackages/Fetch/src/FormDataEntryValue.resand exposefromString,fromFile, and adecodehelper.MessageEventrecord/init types frompackages/WebSockets/src/Types.resby aliasing them inpackages/WebSockets/src/MessageEvent.resinstead of re-defining the record shape.tests/FetchAPI/Request__test.resandtests/FetchAPI/Response__test.res, and drop unused alias bindings intests/Global__test.res.packages/DOM/src/Window.res(alert2,scroll2,scrollTo2,scrollBy2) and keep the descriptive bindings such asalertWithMessage,scrollXY,scrollToXY, andscrollByXY.Co-authored-by: Codex <codex@openai.com>in the commit metadata.Testing
npm test, which runs the build step (rescript), and the run failed due to an existing missing module alias error: the build errored with a missing module aliasReadableStream-WebApiFilereported frompackages/File/src/Blob.res.rescriptcompilation parsed sources and compiled modules before the failure, indicating the changes themselves did not introduce new compiler errors prior to hitting the unrelated missing-alias issue.Codex Task