fix: scroll lock on link click #1186
Merged
+78
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhammerschmidt
added
ok-to-deploy
mediremi
approved these changes
Feb 6, 2026
Member
mediremi
left a comment
mediremi
left a comment
There was a problem hiding this comment.
I tested these changes locally in Firefox at both desktop & mobile viewports, works great 🚀
Collaborator
I've been running into this issue. It's hard to move things around or add to the navigation right now because of this. I tried to do a refactor in place, but it was too difficult to get it correct for each template. This fix is good for now, and I'm planning on breaking up the sidebar layouts into more focused templates and reusable components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the scroll lock when clicking on sidebar links in the right sidebar.
The problem is, we only want scroll-lock on mobile viewports, because the sidebar (dropdown nav menu) overlays the screen there. On other viewport sizes the sidebar is in a different location and always open.
Because the sidebar component is heavily reused I could not figure out a cleaner solution without media queries.