Skip to content

[codex] Deploy guide worker#1302

Merged
jderochervlk merged 5 commits into
masterfrom
codex/guide-worker-deploy
May 21, 2026
Merged

[codex] Deploy guide worker#1302
jderochervlk merged 5 commits into
masterfrom
codex/guide-worker-deploy

Conversation

@jderochervlk
Copy link
Copy Markdown
Collaborator

@jderochervlk jderochervlk commented May 20, 2026

Context

The guide app needs its own Cloudflare Worker deployment target named guide.

Summary

  • Added a deploy-guide CI job to build the guide workspace and deploy it with Wrangler.
  • Guide PR builds now upload Worker versions with a branch preview alias instead of publishing the production guide Worker.
  • Added apps/guide/wrangler.toml configured for the guide Worker and the guide app's out assets directory.
  • Ignored generated root data/api/**/*.json files in oxfmt so API-data regeneration does not keep causing formatting churn.

Validation

  • yarn build:guide completed successfully in the isolated worktree.
  • yarn ci:format passes locally.
  • GitHub Deploy Guide Worker previously passed with versions upload --preview-alias=codex-guide-worker-deploy.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d9190c75d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/deploy.yml Outdated
@fhammerschmidt
Copy link
Copy Markdown
Member

Should we not rather ignore the formatting of api data? After the next deployment it will need formatting again.

@jderochervlk
Copy link
Copy Markdown
Collaborator Author

Should we not rather ignore the formatting of api data? After the next deployment it will need formatting again.

Yeah, that's a good callout.

@github-actions
Copy link
Copy Markdown

Guide Cloudflare deployment

⛅️ wrangler 4.85.0
───────────────────
🌀 Building list of assets...
✨ Read 10 files from the assets directory /home/runner/work/rescript-lang.org/rescript-lang.org/apps/guide/out
🌀 Starting asset upload...
No updated asset files to upload. Proceeding with deployment...
Total Upload: 0.31 KiB / gzip: 0.22 KiB
Worker Startup Time: 0 ms
Uploaded guide (1.95 sec)
Worker Version ID: 9220f141-ca2d-4d74-bc53-5d0587042b37
Version Preview URL: https://9220f141-guide.rescript.workers.dev
Version Preview Alias URL: https://codex-guide-worker-deploy-guide.rescript.workers.dev

To deploy this version to production traffic use the command wrangler versions deploy

Changes to non-versioned settings (config properties 'logpush' or 'tail_consumers') take effect after your next deployment using the command wrangler versions deploy

Changes to triggers (routes, custom domains, cron schedules, etc) must be applied with the command wrangler triggers deploy

@github-actions
Copy link
Copy Markdown

Cloudflare deployment

Deployement ID: 10399d5e-6211-415a-a335-149849a8d230
Deployment Environment: preview

⛅️ wrangler 4.85.0
───────────────────
✨ Compiled Worker successfully
Uploading... (8404/8406)
Uploading... (8405/8406)
Uploading... (8406/8406)
✨ Success! Uploaded 2 files (8404 already uploaded) (1.47 sec)

✨ Uploading _redirects
✨ Uploading Functions bundle
🌎 Deploying...
✨ Deployment complete! Take a peek over at https://10399d5e.rescript-lang.pages.dev
✨ Deployment alias URL: https://codex-guide-worker-deploy.rescript-lang.pages.dev

@jderochervlk
Copy link
Copy Markdown
Collaborator Author

Should we not rather ignore the formatting of api data? After the next deployment it will need formatting again.

Fixed.

@jderochervlk jderochervlk enabled auto-merge (squash) May 21, 2026 00:13
@jderochervlk jderochervlk merged commit 02f7b35 into master May 21, 2026
9 checks passed
@jderochervlk jderochervlk deleted the codex/guide-worker-deploy branch May 21, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants