Installation in an existing project documentation #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevanstannard
changed the title
ryyppy
reviewed
Jan 15, 2021
Member
ryyppy
left a comment
ryyppy
left a comment
There was a problem hiding this comment.
I think this is a good introduction, nothing to complain here.
Co-authored-by: Patrick Ecker <ryyppy@users.noreply.github.com>
…ard/rescript-lang.org into installation-existing-project
Contributor
Author
|
Thanks @ryyppy, ready for re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going through the installation instructions for integrating ReScript into an existing project today.
After installing
bs-platformthe guide indicates to follow the steps for a new project, which refers to cloning the ReScript template, etc.I'm assuming that when integrating into an existing project then we would not follow the template clone steps? If that's the case, then I've drafted some ideas in this PR.
Any feedback appreciated.
Also, just confirming that we should use "JS" as the convention when referring to JavaScript?