Document 'public' feature #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
approved these changes
Oct 5, 2023
Member
zth
left a comment
zth
left a comment
There was a problem hiding this comment.
Fantastic! Could you add it to the JSON schema file in the compiler repo as well, while you're at it? https://github.com/rescript-lang/rescript-compiler/blob/167c586980d1b57d5dc4ac2f82f762d7c03ebce2/docs/docson/build-schema.json
Member
Author
|
It is there already. 
|
Member
|
Public doesn't work in the sources config, only on the top level of bsconfig. At least that's what was reported on the forum. Can you investigate? |
Member
|
... Which also reminds me that I didn't review this properly... sorry! |
Member
Author
|
What? There is no public field on the top level. It's a field in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.