Skip to content

Only paste as json when root is object or array #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2025
Merged

Only paste as json when root is object or array #1148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60da53f
Only paste as json when root is object or array
nojaf Nov 24, 2025
8ccd36c
Add changelog
nojaf Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
> - :house: [Internal]
> - :nail_care: [Polish]
## [Unreleased]

#### :bug: Bug fix

- Only paste objects/arrays are JSON.t https://github.com/rescript-lang/rescript-vscode/pull/1148

## 1.68.0

#### :rocket: New Feature
Expand Down
19 changes: 5 additions & 14 deletions client/src/commands/paste_as_rescript_json.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,7 @@ const isLikelyJson = (text: string): boolean => {
return false;
}
const first = trimmed[0];
if (first === "{" || first === "[" || first === '"' || first === "-") {
return true;
}
if (first >= "0" && first <= "9") {
return true;
}
if (
trimmed.startsWith("true") ||
trimmed.startsWith("false") ||
trimmed.startsWith("null")
) {
return true;
}
return false;
return first === "{" || first === "[";
};

const ensureFloatString = (value: number): string => {
Expand Down Expand Up @@ -99,6 +86,10 @@ export const convertPlainTextToJsonT = (text: string): JsonConversionResult => {

try {
const parsed = JSON.parse(text);
// Only convert objects and arrays, not primitive values
if (typeof parsed !== "object" || parsed === null) {
return { kind: "notJson" };
}
return { kind: "success", formatted: formatJsonValue(parsed) };
} catch {
return {
Expand Down