fix: update globs to work on windows with WSL#1178
fix: update globs to work on windows with WSL#1178nojaf merged 1 commit intorescript-lang:masterfrom
Conversation
be5828d to
b08ca4b
Compare
b08ca4b to
d9c5d7b
Compare
cristianoc
left a comment
There was a problem hiding this comment.
Thanks for the fix.
Nit: there are more lines changed than needed, kind of makes it difficult to see the actual differences.
|
Also, any thoughts to prevent regressions here? |
|
@cristianoc can the recent e2e test setup help here? |
It can if tests work on windows. Anyone with a win machine can try to run this: cd client
npm test |
nojaf
left a comment
There was a problem hiding this comment.
Still works for me on Mac.
@jderochervlk can you add some entries in the CHANGELOG.md please.
|
On windows, no WSL, running |
e1d7c25 to
5165a1b
Compare
5165a1b to
536ac75
Compare
I removed some of the extra changes to minimize the difference. |
Added a note to the changelog. |
This was mostly trial and error to figure out, but eventually I got it working.
Paths for WSL resolve differently so the simple glob pattern wasn't working.
Instead of setting
globPatternas a string I changed them to definebaseUriandpatternas separate values.This only works when you have
incrementalTypecheckingenabled, but I like that anyway. We might want to document that for windows users.Before
Index.res.-.rescript-lang.org.WSL_.Ubuntu-22.04.-.Visual.Studio.Code.2026-02-02.15-46-47.mp4
After
Index.res.-.rescript-lang.org.WSL_.Ubuntu-22.04.-.Visual.Studio.Code.2026-02-02.15-40-42.mp4