Skip to content

disable warning for invalid module name, delegate it to build system or bsc instead #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobzhang merged 2 commits into from
Aug 18, 2017
+8 −7
Merged

disable warning for invalid module name, delegate it to build system or bsc instead #1900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da643f5
[compiler] conditional remove cunit check
bobzhang Aug 18, 2017
e064f7c
no warning for xx-yy, delegate it to build system instead
bobzhang Aug 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions jscomp/bin/bsdep.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20550,9 +20550,8 @@ let is_unit_name name =
;;

let check_unit_name ppf filename name =
if not (is_unit_name name) then
Location.print_warning (Location.in_file filename) ppf
(Warnings.Bad_module_name name);;

()

(* Compute name of module from output file name *)
let module_of_filename ppf inputfile outputprefix =
Expand Down
5 changes: 2 additions & 3 deletions jscomp/bin/whole_compiler.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20319,9 +20319,8 @@ let is_unit_name name =
;;

let check_unit_name ppf filename name =
if not (is_unit_name name) then
Location.print_warning (Location.in_file filename) ppf
(Warnings.Bad_module_name name);;

()

(* Compute name of module from output file name *)
let module_of_filename ppf inputfile outputprefix =
Expand Down
5 changes: 4 additions & 1 deletion vendor/ocaml/driver/compenv.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,13 @@ let is_unit_name name =
;;

let check_unit_name ppf filename name =
#if undefined BS_NO_COMPILER_PATCH then
()
#else
if not (is_unit_name name) then
Location.print_warning (Location.in_file filename) ppf
(Warnings.Bad_module_name name);;

#end
(* Compute name of module from output file name *)
let module_of_filename ppf inputfile outputprefix =
let basename = Filename.basename outputprefix in
Expand Down