[Belt] Change reduceReverse to reduceRight, etc. #2631
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobzhang
reviewed
Mar 15, 2018
| [@@ocaml.deprecated "Use mapRight instead"] | ||
|
|
||
| val mapRight: 'a t -> ('a -> 'b) -> 'b t | ||
| (** [mapRight a f] |
Member
There was a problem hiding this comment.
the name mapRight does not feel right to me, what do other people think?
Member
Author
There was a problem hiding this comment.
I agree... mapRight/mapReverse doesn't sound like something we should expose
Member
There was a problem hiding this comment.
@cullophid for perf reasons, mapReverse is in general faster than map (more true in native backend), it is also available in original stdlib.
I feel Reverse is a better name than Right which does not assume the direction, note my original name is Right, but later changed to Reverse per feedback, now changed again per feedback...
There was a problem hiding this comment.
@bobzhang ah and because ocaml has sideeffects the order actually makes a difference.
Addresses feedback regarding similarity to JS terminology. Fewer keystrokes, so I guess it's nice anyway. Same for the uncurried version, and map. Hopefully this is the last piece of naming-related bikeshedding we need to do for a while.
Collaborator
|
closing very old PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback regarding similarity to JS terminology. Fewer keystrokes, so I guess it's nice anyway.
Same for the uncurried version, and map.
Hopefully this is the last piece of naming-related bikeshedding we need to do for a while.