[Playground] activate super-errors #2695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC. Feedback welcome. cc @bobzhang Huge quality improvement for the online experience. This activates color (needed, otherwise it's a wall of white text). I use a small lib to parse the raw ANSI color escape chars into html styles. It'd not look good in the BS playground currently. This doesn't activate Reason syntax for outcome printer, since it's compiling ocaml.
Member
Author
|
Before: After: |
Contributor
|
Could we make it such that |
Member
Author
|
That’ll be done on the playground side |
Member
|
can we make it configurable so that it would be less intrusive? |
jsoo doesn't support variadic functions, so instead of exposing an optional toggle on the function, I'm exposing two new functions
Member
Author
|
Done. jsoo doesn't support variadic functions, so instead of exposing an optional toggle on the function, I'm exposing two new functions |
Member
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. Feedback welcome. cc @bobzhang
Huge quality improvement for the online experience. This activates
color (needed, otherwise it's a wall of white text). I use a small lib
to parse the raw ANSI color escape chars into html styles. It'd not look
good in the BS playground currently.
This doesn't activate Reason syntax for outcome printer, since it's
compiling ocaml.