Adding a package-lock.json, and supporting an opam local-switch#2985
Closed
ELLIOTTCABLE wants to merge 1 commit intorescript-lang:masterfrom
Closed
Adding a package-lock.json, and supporting an opam local-switch#2985ELLIOTTCABLE wants to merge 1 commit intorescript-lang:masterfrom
ELLIOTTCABLE wants to merge 1 commit intorescript-lang:masterfrom
Conversation
Member
|
@ELLIOTTCABLE Thanks for having a look! I am a bit confused about package.json lock file, since we dont really depend on any npm packages. our package.json may be a little confusing, all dev dependencies are optional that are not really needed in the CI |
ELLIOTTCABLE
force-pushed
the
opam-2-note
branch
from
298329a to
9a99b45
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies if the lack of the package-lock.json was intentional for some build-system reason that I don't understand; but in theory at least, this should make builds more reproducible for contributors / CI.
Also, switches work slightly differently on the new opam 2.0; so I updated the documentation correspondingly.
(Just a little pull-req as I get warmed up on contributing; hope it's welcome!)