work around windows path escaping rules #4847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note this was not exposed because we used to have: ``` src_root = C:\Users\xx\yy|x.t .... $src_root\heelo.txt ``` In this case `:` is read via ReadVar, it is not escaped, if we follow the pattern of build statement, we should have it escaped properly for `:`
if g_finger is empty, it is -0
bobzhang
force-pushed
the
install_fix_for_windows
branch
from
14d9e72 to
9b1b4be
Compare
Member
Author
|
it seems the windows workflow works, however, we got such error quite often: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this was not exposed because we used to have:
In this case
:is read via ReadVar, it is not escaped, if we follow the pattern of build statement, we should have it escaped properly for: