jsxDom: Fix typo in aria-level #5702
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Sep 26, 2022
Member
|
Thanks for catching this typo! |
Member
Author
|
Will this be merged to be part of 10.1? |
Collaborator
Yes. |
Collaborator
|
In fact there's not even a reason to update master at the moment. It can be done all at once later. |
cristianoc
reviewed
Sep 30, 2022
| (* [@ns.optional] [@bs.as "aria-haspopup"] ariaHaspopup: false|true|menu|listbox|tree|grid|dialog, *) | ||
| ariaLevel: int | ||
| [@ns.optional] [@bs.as "aria-lavel"]; | ||
| [@ns.optional] [@bs.as "aria-level"]; |
Collaborator
There was a problem hiding this comment.
nit: @bs.as is now called @as.
Member
Author
|
Closing as the 10.1 branch will get merged into master eventually, and it is solved there already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-level