-
Notifications
You must be signed in to change notification settings - Fork 473
Add some missing DOM props #5711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cknitt
commented
Oct 1, 2022
- Add missing DOM props from rescript-react issues and PRs
- Add fix from jsxDom: Fix typo in aria-level #5702
|
Vaguely related, but has there been discussions recently on if we can tackle specializing the dom props types so they match each HTML element? Ie div doesn't have the same dom props as input, etc. |
In general, that requires an ad-hoc mechanism outside the language (e.g. some special computation in the JSX), or some form of subtyping. Perhaps even just describing what those types should look like would be useful as that would allow to answer the question of what mechanism is required. |
That would be worthy. Currently some fields in domProps only related to specific element, such as "x", "x1, "x2" is for |
This syntax will make defining domProps tasks much easier! |
|
One reason for describing the types in some form is to help see exactly how much expressivity is required. |
|
Can we move the discussion to a separate issue and merge the PR? |