Skip to content

Conversation

@cristianoc
Copy link
Collaborator

Add support for @@live/@@dead to set a default liveness annotation for subsequent items in a module/file scope, inheriting into nested modules and allowing later overrides.

Add focused DCE fixtures covering override + scope boundaries and live-vs-dead liveness propagation.

Update reanalyze deadcode expected output.

Add support for @@live/@@dead to set a default liveness annotation for subsequent items in a module/file scope, inheriting into nested modules and allowing later overrides.

Add focused DCE fixtures covering override + scope boundaries and live-vs-dead liveness propagation.

Update reanalyze deadcode expected output.
@cristianoc cristianoc force-pushed the reanalyze-scoped-annotations branch from fde904e to 48534a3 Compare January 20, 2026 08:33
@cristianoc cristianoc requested a review from cknitt January 20, 2026 08:33
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fde904ea48

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 20, 2026

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@8197

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@8197

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@8197

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@8197

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@8197

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@8197

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@8197

commit: 9ca4559

Fix CollectAnnotations so top-level [@@ocaml.warning("-32")] / [@@warning] continues to suppress dead-value warnings even with scoped @@live/@@dead support.

Add regression fixture and update expected deadcode output.
@cristianoc cristianoc merged commit 726f250 into master Jan 20, 2026
47 of 49 checks passed
@cristianoc cristianoc deleted the reanalyze-scoped-annotations branch January 20, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants