Resolve workspace dependencies in editor analysis#8392
Merged
cknitt merged 2 commits intorescript-lang:masterfrom Apr 28, 2026
Merged
Resolve workspace dependencies in editor analysis#8392cknitt merged 2 commits intorescript-lang:masterfrom
cknitt merged 2 commits intorescript-lang:masterfrom
Conversation
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
cristianoc
approved these changes
Apr 28, 2026
Collaborator
cristianoc
left a comment
cristianoc
left a comment
There was a problem hiding this comment.
Legit. There's code to read .sourcedirs.json in reanalyze too -- not sure if worth sharing as written in different style.
cknitt
force-pushed
the
analysis-dependency-resolution
branch
from
58ef19c to
56ea128
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This was blocking #7525.)
Summary
Editor analysis now resolves dependencies from the package graph that the build system records in
lib/bs/.sourcedirs.json. This makes analysis follow the same resolved dependency roots as compilation for workspace/package-manager layouts.The existing
node_moduleslookup remains as a fallback for dependencies that are not present in.sourcedirs.json.Motivation
Workspace dependencies can compile successfully without a package-local
node_modules/<dependency>entry. Before this change, editor analysis still depended on thatnode_moduleslayout, so it could skip dependency modules that the build had already resolved.That mismatch can break completions, hovers, type expansion, and other analysis features even when the project itself builds. Reading the build system's resolved package roots removes that mismatch.
This also avoids reimplementing package-manager-specific workspace resolution in analysis. The build system already knows the dependency roots and writes them to
.sourcedirs.json; analysis now consumes that information.Testing
make -C tests/analysis_tests/tests-sourcedirs-dependency test