analysis refactor: remove global state Shared_types.state

[aspeddro]

The old global state kept shared mutable caches for: packages by root, URI to root mapping and CMT file cache. That is okay for short CLI calls, but bad for a long-running server because stale cached data can survive across unrelated requests, workspaces, or project changes. A server needs state scoped to the server lifecycle so caches can be isolated and eventually reset/recreated

• Removed the global Shared_types.state; added Shared_types.create_state.
• CLI creates one analysis state per invocation and passes it through Cli/Commands.

Cherry-pick of #8425

[codecov]

Codecov Report

❌ Patch coverage is 4.12371% with 93 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.91%. Comparing base (62ecbbc) to head (1cc53fe).

Files with missing lines	Patch %	Lines
analysis/src/completion_back_end.ml	0.00%	39 Missing ⚠️
analysis/src/type_utils.ml	0.00%	24 Missing ⚠️
analysis/src/references.ml	0.00%	18 Missing ⚠️
analysis/src/resolve_path.ml	0.00%	7 Missing ⚠️
analysis/src/cmt.ml	66.66%	1 Missing ⚠️
analysis/src/completion_jsx.ml	0.00%	1 Missing ⚠️
analysis/src/dot_completion_utils.ml	0.00%	1 Missing ⚠️
analysis/src/process_cmt.ml	0.00%	1 Missing ⚠️
tools/src/tools.ml	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8465      +/-   ##
==========================================
- Coverage   60.91%   60.91%   -0.01%     
==========================================
  Files         374      374              
  Lines       54095    54099       +4     
==========================================
+ Hits        32953    32955       +2     
- Misses      21142    21144       +2     

Files with missing lines	Coverage Δ
analysis/src/completion_expressions.ml	0.00% <ø> (ø)
analysis/src/packages.ml	53.63% <100.00%> (ø)
analysis/src/shared_types.ml	21.95% <ø> (+0.27%)	⬆️
tools/src/migrate.ml	0.00% <ø> (ø)
analysis/src/cmt.ml	30.00% <66.66%> (ø)
analysis/src/completion_jsx.ml	0.00% <0.00%> (ø)
analysis/src/dot_completion_utils.ml	0.00% <0.00%> (ø)
analysis/src/process_cmt.ml	60.89% <0.00%> (ø)
tools/src/tools.ml	20.36% <50.00%> (+0.18%)	⬆️
analysis/src/resolve_path.ml	28.72% <0.00%> (ø)
... and 3 more

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pkg-pr-new]

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8465

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8465

@rescript/darwin-x64

npm i https://pkg.pr.new/@rescript/darwin-x64@8465

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8465

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8465

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8465

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8465

commit: 1cc53fe

[aspeddro]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[fhammerschmidt]

@codex can you check if there is at most only one state in existence that we pass through? I guess it is ok to have multiple create_state() because those are all different entry points but that is not easily verifiable from just the diff.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[fhammerschmidt]

ok verified it myself locally, looks good!