Better support for modules #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
881aae7 contains some improvements. |
aspeddro
commented
Sep 21, 2022
| module_expression: $ => choice( | ||
| $.module_identifier, | ||
| $.module_identifier_path, | ||
| $.type_identifier_path, |
Collaborator
Author
There was a problem hiding this comment.
type_identifier_path to match module_pack in type_declaration
type t = Ok | Failed(module(Component.t))
// ^ here
Collaborator
Author
|
The commit 630e76a covers more cases and add more tests. |
Collaborator
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
module_packin parametershttps://github.com/rescriptbr/rescript-urql/blob/main/src/Client.res#L248-L251
Support
module_packafterashttps://github.com/rescriptbr/rescript-urql/blob/main/src/Client.res#L327
Other changes
module_pack_typerepeat1(seq($.module_identifier, '.'))constrain_moduleandconstrain_type