Sail

[gspinaci]

Why

The SQLSail business core was outdated and integrated only in the branch build-docker/archipelago. With the SQLSail integrated in the master, we can merge all the modifications Villa i Tatti did on semantic-map.

What

In MpRepositoryVocabulary.java, I added the required namespaces. AbstractServiceWrappingSailConfig.java and AbstractServiceWrappingSailConnection.java have been generalised. The latter with another method to override to handle other type of results, not only streams.

I created the classes SQLSail.java, SQLSailConfig.java, SQLSailFactory.java, and SQLSailConnection.java where the business logic for SQLSail is contained.

Video / Gif / Screenshot

No changes in the UI

Meta

The code was required to add another abstract method in AbstractServiceWrappingSailConnection.java to have other classes (RestSail, and SQLSail) extend it without worrying for different types.

How To Test

@aindlq we should define a common way to create Unit Test for SQL connections.

[gspinaci]

@giancrys84 I have the help page ready. Where should I add it?

[giancrys84]

Hi @gspinaci, for the time being add the help page here https://drive.google.com/drive/folders/1gNF44hd8k4l9YIZT-CmxNc0qR6xxtvdr
Thanks!

[gspinaci]

Hi all, the documentation is online: https://docs.google.com/document/d/1lz6vcVqVXbYsJLewqhooCYN23HBlvl090PwKtqIPqDQ/edit?usp=sharing

[dianat]

Hi,

I followed your documentation (thank you), but I kept getting a null error. I've traced it back to the way the output parameter was set, I think I've corrected the problem, but please have a look as well @gspinaci

Hi all, the documentation is online: https://docs.google.com/document/d/1lz6vcVqVXbYsJLewqhooCYN23HBlvl090PwKtqIPqDQ/edit?usp=sharing

[gspinaci]

Hi @dianat! Thanks for testing! I am currently working on providing better documentation and a test/default app.

[gspinaci]

Hi @dianat, Thanks for fixing the bug. It works perfectly fine with this fix. Moreover, I updated the documentation and created a custom app (https://github.com/villaitatti/RS_SQLSAIL_test) for testing purposes.

Also, in the documentation folder, you can find the dump of the artworks table in CSV format.

[dianat]

Documentation:
https://docs.google.com/document/d/1lz6vcVqVXbYsJLewqhooCYN23HBlvl090PwKtqIPqDQ/edit?usp=sharing

Example custom app (https://github.com/villaitatti/RS_SQLSAIL_test) for testing purposes.

Also, in the documentation folder, you can find the dump of the artworks table in CSV format.