feat(RestApi): Trigger versioning cleanup every 10th app start to save resources#271
Merged
Conversation
Catfriend1
temporarily deployed
to
dev-sign-untrusted
GitHub Actions
Inactive
Contributor
|
🤖 This pull request has been automatically locked because it was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: triggered on every app start, potentially traversing large directory trees with Android's slow SAF or FS layer (especially on Android 11)
After: trigger every 10th app start so cleanup is not missed if the user occasionally and manually starts and exits the app
This will not (visibly) affect installs where Syncthing is configured to run continously with uptimes greater than the default cleanup interval S which is 3600s