-
Notifications
You must be signed in to change notification settings - Fork 871
fix(react-email): Missing URL on global context for email VM #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3d045d3 to
833b135
Compare
pkit
reviewed
Jan 28, 2024
833b135 to
13015b6
Compare
|
URLSearchParams I get this not defined in my env, wondering if this can be added as well? |
|
@ZiBuDo as you can see even the current PR is un-merged yet. lol |
vcapretz
approved these changes
Mar 4, 2024
bukinoshita
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
As we need to pre-import the modules from Node into the app before loading them with
vmwe also need to define the context in which the code will run for us to get the email's component,
this means that we need to pass in a few other global things like
Bufferthat theglobaldynamically doesn't contain.
What was the issue?
That being said, something that was missing from the global context was the
URLclass,which this PR adds. Closes #1229
How can I test to make sure it's fixed?
npx tsx ../../packages/react-email/src/cli/index.ts devinside of./apps/demo./apps/demo/emails/airbnb-review.tsxby adding the following:URL is not defined