fix(markdown): support nested lists in markdown component #2624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes resend#2599 Previously, nested lists would crash with 'Token with "list" type was not found' error because the listitem renderer used parseInline() which only handles inline tokens. Changes: - Updated listitem renderer to detect nested lists - Use parse() for list items with nested content - Use parseInline() for simple list items (backward compatible) - Added test case for nested lists The fix maintains backward compatibility by only using parse() when needed, preventing unnecessary <p> tag wrapping in simple lists.
|
@actuallyzefe is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 85e1954 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
gabrielmfern
approved these changes
Nov 3, 2025
Member
gabrielmfern
left a comment
gabrielmfern
left a comment
There was a problem hiding this comment.
This look great! Thank you!
|
Thank you for addressing the issue 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2599
Previously, nested lists would crash with 'Token with "list" type was not found' error because the listitem renderer used parseInline() which only handles inline tokens.
Changes:
The fix maintains backward compatibility by only using parse() when needed, preventing unnecessary
tag wrapping in simple lists.
Summary by cubic
Fixes a crash in the Markdown component when rendering nested lists. Nested list items are now parsed as blocks, while simple items remain inline to avoid extra paragraph tags.
Written for commit 85e1954. Summary will update automatically on new commits.