Skip to content

Conversation

@gabrielmfern
Copy link
Member

@gabrielmfern gabrielmfern commented Nov 19, 2025

Using the Preview component outside of the body generates invalid HTML (a div outside of the body) which we shouldn't be doing, specially in our example/starter code. We've already done this for the demo, but missed the places that this pull request fixes


Summary by cubic

Moved all uses of the Preview component inside Body to fix invalid HTML and standardize usage across components, examples, benchmarks, and templates. This prevents rendering a div outside the body in our starter and demo code.

  • Bug Fixes
    • Updated web components (bento-grid, customer-reviews, lists, pricing tables, rating survey, two-tiers).
    • Updated benchmarks and example emails (Tailwind and non-Tailwind, waitlist emails, Scaleway Node).
    • Updated create-email templates (Notion magic link, Stripe welcome, Vercel invite).

Written for commit 0c1b65a. Summary will update automatically on new commits.

@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2025

⚠️ No Changeset found

Latest commit: 0c1b65a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gabrielmfern gabrielmfern requested review from a team and lucasfcosta and removed request for a team November 19, 2025 16:12
@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-email Ready Ready Preview Comment Nov 19, 2025 4:28pm
react-email-demo Ready Ready Preview Comment Nov 19, 2025 4:28pm

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 19, 2025

Open in StackBlitz

npm i https://pkg.pr.new/resend/react-email/create-email@2698

commit: dc16aee

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 22 files

@gabrielmfern gabrielmfern merged commit 5cb8a76 into canary Nov 19, 2025
7 of 8 checks passed
@gabrielmfern gabrielmfern deleted the fix/preview-outside-body-copy-paste-components branch November 19, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants