-
Notifications
You must be signed in to change notification settings - Fork 907
fix(react-email): ensure dev dependencies are in $HOME/.react-email #2904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: c196ea2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
https://vercel.com/resend/resend-emails/FukkGsK4mphebqtHobAnSLceE5Qh#L287
Since Vercel, and most likely other CI environments will have
NODE_ENV=productionset,npm installwon't include cross-env, which is required for thebuildcommand to work in.react-emailforemail build.To fix this, just switching up form using nypm, (since they don't provide a way to define flags for npm like this), and use
npm install --production=falseas instructed. I've also tried the preview release from this and can confirm it works.Summary by cubic
Ensure devDependencies install for the .react-email preview server so email builds work in CI (e.g., Vercel) where NODE_ENV=production skips dev deps. Fixes build errors caused by missing cross-env.
Written for commit c196ea2. Summary will update on new commits.