feat(editor): add global style setter functions to EmailTheming#3122
Merged
gabrielmfern merged 3 commits intofeat/ai-oss-editorfrom Mar 26, 2026
Merged
Conversation
…ted functions to EmailTheming - setGlobalStyles: sets the global panel styles on the editor document - setCurrentTheme: sets the current email theme on the editor document - setGlobalCSSInjected: sets the global CSS string injected into the email <head> All three functions are exported from @react-email/editor/plugins for consumer use. Bumps version from 0.0.0-experimental.34 to 0.0.0-experimental.35. Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
joaopcm
approved these changes
Mar 26, 2026
Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Confidence score: 4/5
- This PR looks safe to merge; the only noted issue is a naming-convention mismatch for an initialism in
packages/editor/src/plugins/email-theming/extension.tsx. - Impact is low and mostly stylistic, but aligning the function name (e.g., camel-cased acronym) will improve consistency and readability.
- Pay close attention to
packages/editor/src/plugins/email-theming/extension.tsx- rename the initialism in the function to match convention.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/editor/src/plugins/email-theming/extension.tsx">
<violation number="1" location="packages/editor/src/plugins/email-theming/extension.tsx:215">
P2: Custom agent: **Initialisms and Acronyms Naming Conventions**
Rename the function to use camel-cased acronym (e.g., setGlobalCssInjected) to comply with the naming convention for initialisms.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Use camel-cased acronym per naming conventions. Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds three new exported functions to the
EmailThemingmodule, allowing consumers of@react-email/editor/pluginsto programmatically update global styles, theme, and CSS injection on the editor document.New Functions
setGlobalStyles(editor, styles)— Sets the global panel styles on the editor document (persists under theGlobalContentnode's'styles'key).setCurrentTheme(editor, theme)— Sets the current email theme ('basic'or'minimal') on the editor document (persists under the'theme'key).setGlobalCssInjected(editor, css)— Sets the global CSS string that gets injected into the email<head>(persists under the'css'key).All three functions use the existing
editor.commands.setGlobalContent()command under the hood and are fully typed.Exports
The functions are exported from
@react-email/editor/pluginsthrough the existing barrel re-export chain:extension.tsx→email-theming/index.ts→plugins/index.ts→@react-email/editor/pluginsVersion Bump
Bumps
@react-email/editorfrom0.0.0-experimental.34→0.0.0-experimental.35for publishing after merge.Slack Thread
Summary by cubic
Expose three helpers in EmailTheming to set global styles, the current theme, and injected CSS on the editor document from
@react-email/editor/plugins. All functions calleditor.commands.setGlobalContent; signatures were tidied.New Features
setGlobalStyles(editor, styles)— set global panel styles.setCurrentTheme(editor, theme)— set the current email theme.setGlobalCssInjected(editor, css)— set CSS injected into the email head.Dependencies
@react-email/editorto0.0.0-experimental.35.Written for commit b069e5f. Summary will update on new commits.