feat(editor): add inspector picker components#3186
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Contributor
|
This review could not be run because your cubic account has exceeded the monthly review limit. If you need help restoring access, please contact contact@cubic.dev. |
commit: |
gabrielmfern
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NumberInput,PaddingPicker,BorderPicker,BorderRadiusPicker,PropRow,Section(withinitialCollapsed)Context
Part of the inspector sidebar redesign (PRODUCT-1739). These composed components sit between the UI primitives (PR #3185) and the upcoming section components (
Inspector.Background,Inspector.Padding, etc.).Skipped
PropertyGroupsandStylePanelfrom the old PR #3173 — those were tied to the JSON-config approach we're replacing.Depends on #3183 (hooks) and #3185 (primitives).
Test plan
pnpm lint:fixpassesSummary by cubic
Add reusable inspector picker components (border, padding, border radius, number) and lightweight layout wrappers to standardize the inspector UI on HTML primitives. This advances the inspector sidebar redesign (PRODUCT-1739).
BorderPicker,PaddingPicker,BorderRadiusPicker: uniform/per-side modes, drag-to-change, and shorthand handling; px/% where applicable.NumberInput: numeric field with unit display/select and drag-to-change.Section(collapsible with optional add/remove) andPropRowfor consistent rows.icons/index.ts.Written for commit 07e5e07. Summary will update on new commits.