Skip to content

feat(editor): add inspector picker components#3186

Merged
joaopcm merged 1 commit intocanaryfrom
feat/inspector-picker-components
Apr 6, 2026
Merged

feat(editor): add inspector picker components#3186
joaopcm merged 1 commit intocanaryfrom
feat/inspector-picker-components

Conversation

@joaopcm
Copy link
Copy Markdown
Member

@joaopcm joaopcm commented Apr 6, 2026

Summary

  • Add 6 picker/layout components: NumberInput, PaddingPicker, BorderPicker, BorderRadiusPicker, PropRow, Section (with initialCollapsed)
  • Add 12 new SVG icons for directional controls (corner markers, panel sides, plus, x, square variants)
  • Add CSS layout rules for prop-row and section components
  • All components adapted to use our simple HTML primitives (not Radix-style APIs from the old approach)

Context

Part of the inspector sidebar redesign (PRODUCT-1739). These composed components sit between the UI primitives (PR #3185) and the upcoming section components (Inspector.Background, Inspector.Padding, etc.).

Skipped PropertyGroups and StylePanel from the old PR #3173 — those were tied to the JSON-config approach we're replacing.

Depends on #3183 (hooks) and #3185 (primitives).

Test plan

  • pnpm lint:fix passes
  • All 119 existing inspector tests still pass
  • All 12 new icons used by the picker components

Summary by cubic

Add reusable inspector picker components (border, padding, border radius, number) and lightweight layout wrappers to standardize the inspector UI on HTML primitives. This advances the inspector sidebar redesign (PRODUCT-1739).

  • New Features
    • BorderPicker, PaddingPicker, BorderRadiusPicker: uniform/per-side modes, drag-to-change, and shorthand handling; px/% where applicable.
    • NumberInput: numeric field with unit display/select and drag-to-change.
    • Section (collapsible with optional add/remove) and PropRow for consistent rows.
    • 12 new SVG icons (corners, panels, square variants, plus, x) exported via icons/index.ts.
    • New CSS rules for prop rows and sections; all components use our HTML primitives (not Radix-style APIs).

Written for commit 07e5e07. Summary will update on new commits.

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Ready Ready Preview, Comment Apr 6, 2026 6:23pm
react-email-demo Ready Ready Preview, Comment Apr 6, 2026 6:23pm
react-email-examples Ready Ready Preview, Comment Apr 6, 2026 6:23pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 6, 2026

⚠️ No Changeset found

Latest commit: 07e5e07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cubic-dev-ai
Copy link
Copy Markdown
Contributor

cubic-dev-ai bot commented Apr 6, 2026

This review could not be run because your cubic account has exceeded the monthly review limit. If you need help restoring access, please contact contact@cubic.dev.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 6, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@react-email/editor@3186

commit: 07e5e07

@joaopcm joaopcm merged commit e6a2157 into canary Apr 6, 2026
16 of 17 checks passed
@joaopcm joaopcm deleted the feat/inspector-picker-components branch April 6, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants