feat(editor): add Inspector.Document defaults and EmailTheming validation#3189
Merged
feat(editor): add Inspector.Document defaults and EmailTheming validation#3189
Conversation
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This review could not be run because your cubic account has exceeded the monthly review limit. If you need help restoring access, please contact contact@cubic.dev. |
commit: |
4 tasks
gabrielmfern
approved these changes
Apr 7, 2026
eda3861 to
864665c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inspector.Documentnow renders default sections (Background + Container) when no children are passedInspector.Providerthrows a clear error ifEmailThemingextension is missingUsage
Context
Final PR in the inspector sidebar redesign stack (PRODUCT-1739). Stacked on top of #3188 (section components).
Test plan
pnpm lint:fixpasseschildrenprop is now optional onInspector.DocumentSummary by cubic
Adds default Background and Container sections to
Inspector.Documentwhen no children are provided, and adds a fail-fast check inInspector.Providerfor theEmailThemingextension. Supports PRODUCT-1739 (inspector sidebar redesign).New Features
Inspector.Documentrenders Background + Container by default when no children are passed.childrenis now optional; the render-props API is unchanged.Inspector.Providerthrows a clear error ifEmailThemingis missing.Migration
EmailThemingextension is included in your editor setup (e.g.,EmailThemingorEmailTheming.configure({...})).Written for commit 864665c. Summary will update on new commits.