Skip to content

fix(ui): fs warnings on every fs import#3484

Merged
gabrielmfern merged 3 commits into
canaryfrom
fix/fs-warnings
May 8, 2026
Merged

fix(ui): fs warnings on every fs import#3484
gabrielmfern merged 3 commits into
canaryfrom
fix/fs-warnings

Conversation

@gabrielmfern
Copy link
Copy Markdown
Member

@gabrielmfern gabrielmfern commented May 8, 2026

Closes DEV-382

Summary by cubic

Stops noisy Node deprecation warnings (DEP0176) from firing on every node:fs import by adjusting how the VM exposes fs exports. Deprecated access mode constants are no longer enumerated, preventing warnings without breaking existing code.

  • Bug Fixes
    • Exclude deprecated fs constants (F_OK, R_OK, W_OK, X_OK) from named exports in runBundledCode, avoiding DEP0176.
    • Keep constants available via the default fs export; behavior remains the same for users.
    • Add a regression test to ensure no warnings on regular node:fs imports; publish patch for @react-email/ui.

Written for commit 251c12b. Summary will update on new commits.

Signed-off-by: Gabriel Miranda <gabrielmfern@outlook.com>
Signed-off-by: Gabriel Miranda <gabrielmfern@outlook.com>
Signed-off-by: Gabriel Miranda <gabrielmfern@outlook.com>
@gabrielmfern gabrielmfern requested a review from dielduarte May 8, 2026 20:09
@gabrielmfern gabrielmfern self-assigned this May 8, 2026
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Ready Ready Preview, Comment May 8, 2026 8:11pm
react-email-demo Ready Ready Preview, Comment May 8, 2026 8:11pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 8, 2026

🦋 Changeset detected

Latest commit: 251c12b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@react-email/ui Patch
react-email Patch
@react-email/editor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Low-impact bug fix that silences Node deprecation warnings by filtering out deprecated fs constants from synthetic module exports. Logic is isolated, well-documented, and includes a regression test.No

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 8, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@react-email/ui@3484

commit: 251c12b

@gabrielmfern gabrielmfern merged commit 8cabf52 into canary May 8, 2026
15 of 16 checks passed
@gabrielmfern gabrielmfern deleted the fix/fs-warnings branch May 8, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants