Skip to content

fix(cli): dependency installation not including dev dependencies#3499

Merged
gabrielmfern merged 3 commits into
canaryfrom
chore/fix-npm-install
May 13, 2026
Merged

fix(cli): dependency installation not including dev dependencies#3499
gabrielmfern merged 3 commits into
canaryfrom
chore/fix-npm-install

Conversation

@gabrielmfern
Copy link
Copy Markdown
Member

@gabrielmfern gabrielmfern commented May 13, 2026

Summary by cubic

Fixes email build installs by including dev dependencies and standardizes the build to always use npm. This resolves build failures in the generated .react-email app.

  • Bug Fixes

    • Set NPM_CONFIG_INCLUDE=dev during dependency install in .react-email.
    • Use npm for both installDependencies and runScript('build') via nypm.
  • Migration

    • --packageManager is deprecated and ignored; email build always uses npm. The option is hidden from --help, has no default, and shows a runtime warning if passed.

Written for commit 4e30e0b. Summary will update on new commits.

Signed-off-by: gabriel miranda <gabriel@resend.com>
Signed-off-by: gabriel miranda <gabriel@resend.com>
@gabrielmfern gabrielmfern self-assigned this May 13, 2026
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Ready Ready Preview, Comment May 13, 2026 3:13pm
react-email-demo Ready Ready Preview, Comment May 13, 2026 3:13pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 13, 2026

🦋 Changeset detected

Latest commit: 4e30e0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
react-email Patch
@react-email/editor Patch
@react-email/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: These changes fix a specific bug in CLI dependency handling by including dev dependencies and standardizing the package manager to npm, with low blast radius limited to the build command and proper deprecation warnings.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 13, 2026

Open in StackBlitz

npm i https://pkg.pr.new/react-email@3499

commit: 4e30e0b

Signed-off-by: gabriel miranda <gabriel@resend.com>
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Requires human review: This change modifies core build logic by hardcoding npm usage and adding environment variable manipulation for dependency installation, which carries moderate risk of build failures or regressions for users relying on the now-deprecated package manager option.

@gabrielmfern gabrielmfern merged commit ad6a9de into canary May 13, 2026
16 of 17 checks passed
@gabrielmfern gabrielmfern deleted the chore/fix-npm-install branch May 13, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant