fix(cli): dependency installation not including dev dependencies#3499
Conversation
Signed-off-by: gabriel miranda <gabriel@resend.com>
Signed-off-by: gabriel miranda <gabriel@resend.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 4e30e0b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: These changes fix a specific bug in CLI dependency handling by including dev dependencies and standardizing the package manager to npm, with low blast radius limited to the build command and proper deprecation warnings.
commit: |
Signed-off-by: gabriel miranda <gabriel@resend.com>
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Requires human review: This change modifies core build logic by hardcoding npm usage and adding environment variable manipulation for dependency installation, which carries moderate risk of build failures or regressions for users relying on the now-deprecated package manager option.
Summary by cubic
Fixes
email buildinstalls by including dev dependencies and standardizes the build to always usenpm. This resolves build failures in the generated.react-emailapp.Bug Fixes
NPM_CONFIG_INCLUDE=devduring dependency install in.react-email.npmfor bothinstallDependenciesandrunScript('build')vianypm.Migration
--packageManageris deprecated and ignored;email buildalways usesnpm. The option is hidden from--help, has no default, and shows a runtime warning if passed.Written for commit 4e30e0b. Summary will update on new commits.