Skip to content

fix: spinner rendering for non tty environments#3503

Merged
gabrielmfern merged 1 commit into
canaryfrom
fix/spinners-in-non-tty-environment
May 13, 2026
Merged

fix: spinner rendering for non tty environments#3503
gabrielmfern merged 1 commit into
canaryfrom
fix/spinners-in-non-tty-environment

Conversation

@gabrielmfern
Copy link
Copy Markdown
Member

@gabrielmfern gabrielmfern commented May 13, 2026

Summary by cubic

Fixes spinner output on non-TTY streams (CI, pipes, dumb terminals) by switching to a non-interactive mode that prints each status once instead of animating frames. Updates spinner utils in react-email and ui; TTY behavior is unchanged.

  • Bug Fixes
    • Detect non-interactive streams (!isTTY, TERM=dumb, or CI) and use a non-interactive spinner.
    • In non-TTY, log only new text lines, trim trailing newlines, and persist final success/fail lines with symbols.
    • Added tests for non-TTY behavior and updated tree snapshot.

Written for commit 8958873. Summary will update on new commits.

Signed-off-by: gabriel miranda <gabriel@resend.com>
@gabrielmfern gabrielmfern requested a review from dielduarte May 13, 2026 16:12
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 13, 2026

🦋 Changeset detected

Latest commit: 8958873

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
react-email Patch
@react-email/editor Patch
@react-email/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Ready Ready Preview, Comment May 13, 2026 4:14pm
react-email-demo Ready Ready Preview, Comment May 13, 2026 4:14pm

Request Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 13, 2026

Open in StackBlitz

npm i https://pkg.pr.new/react-email@3503
npm i https://pkg.pr.new/@react-email/ui@3503

commit: 8958873

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: This PR safely adds a non-interactive spinner that only prints each status line once in CI/piped terminals, with thorough tests and a separate codepath that does not affect existing TTY behavior.

@gabrielmfern gabrielmfern merged commit 1c386ce into canary May 13, 2026
15 of 16 checks passed
@gabrielmfern gabrielmfern deleted the fix/spinners-in-non-tty-environment branch May 13, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants