Skip to content

fix(web): hide bubble menu when divider is selected in full-email-builder example#3504

Merged
gabrielmfern merged 1 commit into
canaryfrom
fix/full-email-builder-divider-bubble-menu
May 13, 2026
Merged

fix(web): hide bubble menu when divider is selected in full-email-builder example#3504
gabrielmfern merged 1 commit into
canaryfrom
fix/full-email-builder-divider-bubble-menu

Conversation

@dielduarte
Copy link
Copy Markdown
Contributor

@dielduarte dielduarte commented May 13, 2026

Summary

  • Adds 'horizontalRule' to hideWhenActiveNodes in the full-email-builder example so the text bubble menu no longer appears when a divider block is selected.

Context

The bubble menu trigger (textSelection) now correctly suppresses the menu for any NodeSelection whose node type is in hideWhenActiveNodes (fixed in the companion PR). This change updates the example to opt in to that behavior for the divider.

Test plan

  • Open the full-email-builder example (/editor/full-email-builder)
  • Add a divider block via the slash command
  • Click the divider — bubble menu should not appear

🤖 Generated with Claude Code


Summary by cubic

Hide the text bubble menu when a divider is selected in the full-email-builder example by adding horizontalRule to the BubbleMenu’s hideWhenActiveNodes list.

Written for commit b16be0f. Summary will update on new commits.

…lder example

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Ready Ready Preview, Comment May 13, 2026 4:22pm
react-email-demo Ready Ready Preview, Comment May 13, 2026 4:22pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 13, 2026

⚠️ No Changeset found

Latest commit: b16be0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: This change adds 'horizontalRule' to the hideWhenActiveNodes list in the BubbleMenu of a full-email-builder example, preventing the bubble menu from appearing when a divider is selected; it is a trivial UI configuration change with no impact on core logic or production systems.

@gabrielmfern gabrielmfern merged commit ff8dd56 into canary May 13, 2026
15 of 16 checks passed
@gabrielmfern gabrielmfern deleted the fix/full-email-builder-divider-bubble-menu branch May 13, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants