fix(ui): possible security issue with email file access#3534
Merged
gabrielmfern merged 2 commits intoMay 25, 2026
Merged
Conversation
Signed-off-by: gabriel miranda <gabriel@resend.com>
🦋 Changeset detectedLatest commit: 03bea3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
felipefreitag
approved these changes
May 25, 2026
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Requires human review: This PR implements a security guard against path traversal in file access functions, and although the implementation appears correct and includes comprehensive tests, security-sensitive changes should be reviewed by a human to ensure there are no edge cases or bypasses that could lead to...
Re-trigger cubic
gabrielmfern
deleted the
feature/dev-794-codeql-jspath-injection-in-react-email-285
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Blocks path traversal in the preview server by rejecting email paths that resolve outside the configured emails directory. Addresses Linear DEV-794 and the CodeQL
js/path-injectionalert.isPathWithinEmailsDirectoryto validate paths usingrealpath; blocks../escapes, absolute paths, symlink escapes; fails closed ifREACT_EMAIL_INTERNAL_EMAILS_DIR_ABSOLUTE_PATHis unset.renderEmailByPathto return an error when the path is outside the emails directory.getEmailPathFromSlugso only in-root files are returned; otherwiseundefined.Written for commit 03bea3c. Summary will update on new commits. Review in cubic