Skip to content

feat(skill): add email accessibility guidance to skill#3551

Merged
christina-de-martinez merged 4 commits into
canaryfrom
pr-3550
May 28, 2026
Merged

feat(skill): add email accessibility guidance to skill#3551
christina-de-martinez merged 4 commits into
canaryfrom
pr-3550

Conversation

@christina-de-martinez
Copy link
Copy Markdown
Collaborator

@christina-de-martinez christina-de-martinez commented May 27, 2026

Summary by cubic

Update react-email skill docs with practical accessibility guidance aligned to the latest react-email defaults and EMC 2026. Clarifies alt-text (descriptive for meaningful images, explicit alt="" for decorative), documents defaults (<Html lang/dir>, <Img alt="">, layout tables with role="presentation", <Preview> adds <title>), and tightens guidance on headings, link text, contrast, and locale.

  • New Guidance
    • Linked images are never decorative; their alt must describe the destination.
    • Very short messages may omit the <h1>.
    • Adds a link to the full accessibility reference and checklist.

Written for commit 40505d6. Summary will update on new commits.

Review in cubic

hermesresend and others added 3 commits May 27, 2026 22:20
Updates the react-email skill so agents using it produce accessible
emails by default:

- SKILL.md: rewrites the alt-text rule (no more 'always include alt text'
  which is wrong for decorative images) and adds an Accessibility section
  covering what React Email handles for free vs. what the author still
  has to do (headings, link copy, contrast, locale).
- COMPONENTS.md: notes that <Img> defaults to alt="", clarifies meaningful
  vs. decorative image guidance, and documents that <Section>, <Row>,
  <Container>, and <Markdown> tables render role="presentation" by default.
- STYLING.md: aligns alt-text guidance and adds a decorative-image example.

Aligns with the new <https://emailmarkup.org/en/reports/accessibility/2026/|EMC 2026 accessibility report> findings and the
react-email defaults shipped in the latest release.
Omitting the alt attribute is not equivalent to alt="". Some screen
readers announce the filename when alt is missing, so decorative
images must carry an explicit empty alt. Updates examples and wording
to make this unambiguous.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 27, 2026

⚠️ No Changeset found

Latest commit: 40505d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Ready Ready Preview, Comment May 27, 2026 11:54pm
react-email-demo Ready Ready Preview, Comment May 27, 2026 11:54pm

Per the EMC 2026 report, a linked image is functional, not
decorative \u2014 its alt must describe where the link goes. Adds
that rule to the Accessibility section and to the <Img>
component reference.

Also drops the 0.002% stat (the percentage is decoration for an
agent skill; the actionable rules and link to the full reference
in the email-best-practices skill are what matter) and notes the
short-message exception for <h1>.
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Auto-approved: These changes are strictly documentation updates that add accessibility guidance to skill files, with no modifications to source code, configuration, or any deployable assets, so the risk of breaking anything is negligible.

Re-trigger cubic

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: This is a documentation-only update that adds accessibility guidance to React Email skill docs, with no changes to source code, business logic, or infrastructure, and is thus low-risk and safe to auto-approve.

Re-trigger cubic

@cpenned cpenned marked this pull request as ready for review May 28, 2026 02:45
@cpenned cpenned changed the title docs(skill): add email accessibility guidance to skill feat(skill): add email accessibility guidance to skill May 28, 2026
@christina-de-martinez christina-de-martinez merged commit 6107e01 into canary May 28, 2026
18 of 21 checks passed
@christina-de-martinez christina-de-martinez deleted the pr-3550 branch May 28, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants