Merged
Conversation
felipefreitag
approved these changes
Mar 17, 2026
Contributor
There was a problem hiding this comment.
2 issues found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/lint.yml">
<violation number="1" location=".github/workflows/lint.yml:9">
P2: Restrict `GITHUB_TOKEN` to read-only permissions in this build-only workflow. Without an explicit `permissions` block, the checkout/install/lint steps inherit the repository default token scopes, which can be write-enabled.</violation>
</file>
<file name=".github/workflows/test.yml">
<violation number="1" location=".github/workflows/test.yml:6">
P2: Add an explicit read-only `permissions` block for this checkout-and-test workflow. Otherwise it inherits repo/org default `GITHUB_TOKEN` permissions, which can be broader than necessary.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| concurrency: | ||
| group: lint-${{ github.ref }} | ||
| cancel-in-progress: true | ||
| jobs: |
Contributor
There was a problem hiding this comment.
P2: Restrict GITHUB_TOKEN to read-only permissions in this build-only workflow. Without an explicit permissions block, the checkout/install/lint steps inherit the repository default token scopes, which can be write-enabled.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/lint.yml, line 9:
<comment>Restrict `GITHUB_TOKEN` to read-only permissions in this build-only workflow. Without an explicit `permissions` block, the checkout/install/lint steps inherit the repository default token scopes, which can be write-enabled.</comment>
<file context>
@@ -0,0 +1,20 @@
+concurrency:
+ group: lint-${{ github.ref }}
+ cancel-in-progress: true
+jobs:
+ lint:
+ runs-on: blacksmith-2vcpu-ubuntu-2204
</file context>
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| concurrency: |
Contributor
There was a problem hiding this comment.
P2: Add an explicit read-only permissions block for this checkout-and-test workflow. Otherwise it inherits repo/org default GITHUB_TOKEN permissions, which can be broader than necessary.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/test.yml, line 6:
<comment>Add an explicit read-only `permissions` block for this checkout-and-test workflow. Otherwise it inherits repo/org default `GITHUB_TOKEN` permissions, which can be broader than necessary.</comment>
<file context>
@@ -0,0 +1,20 @@
+ push:
+ branches: [main]
+ pull_request:
+concurrency:
+ group: test-${{ github.ref }}
+ cancel-in-progress: true
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Split the monolithic CI into four workflows—Lint, Typecheck, Test, and Smoke—for clearer status checks and targeted reruns.
.github/workflows/ci.ymland added.github/workflows/lint.yml,typecheck.yml,test.yml, andsmoke.yml.mainand on PRs with its own concurrency group.pnpm); Smoke builds the Node bundle andpkgbinary and runs version/help smoke tests.Written for commit 9870a1f. Summary will update on new commits.