Skip to content

refactor: breakdown ci#120

Merged
bukinoshita merged 1 commit intomainfrom
refactor/breakdown-ci
Mar 17, 2026
Merged

refactor: breakdown ci#120
bukinoshita merged 1 commit intomainfrom
refactor/breakdown-ci

Conversation

@bukinoshita
Copy link
Member

@bukinoshita bukinoshita commented Mar 17, 2026


Summary by cubic

Split the monolithic CI into four workflows—Lint, Typecheck, Test, and Smoke—for clearer status checks and targeted reruns.

  • Refactors
    • Removed .github/workflows/ci.yml and added .github/workflows/lint.yml, typecheck.yml, test.yml, and smoke.yml.
    • Each workflow runs on push to main and on PRs with its own concurrency group.
    • Standardized setup (Node 24 + pnpm); Smoke builds the Node bundle and pkg binary and runs version/help smoke tests.

Written for commit 9870a1f. Summary will update on new commits.

@bukinoshita bukinoshita merged commit ea69cd8 into main Mar 17, 2026
15 checks passed
@bukinoshita bukinoshita deleted the refactor/breakdown-ci branch March 17, 2026 12:48
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 5 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/lint.yml">

<violation number="1" location=".github/workflows/lint.yml:9">
P2: Restrict `GITHUB_TOKEN` to read-only permissions in this build-only workflow. Without an explicit `permissions` block, the checkout/install/lint steps inherit the repository default token scopes, which can be write-enabled.</violation>
</file>

<file name=".github/workflows/test.yml">

<violation number="1" location=".github/workflows/test.yml:6">
P2: Add an explicit read-only `permissions` block for this checkout-and-test workflow. Otherwise it inherits repo/org default `GITHUB_TOKEN` permissions, which can be broader than necessary.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

concurrency:
group: lint-${{ github.ref }}
cancel-in-progress: true
jobs:
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Restrict GITHUB_TOKEN to read-only permissions in this build-only workflow. Without an explicit permissions block, the checkout/install/lint steps inherit the repository default token scopes, which can be write-enabled.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/lint.yml, line 9:

<comment>Restrict `GITHUB_TOKEN` to read-only permissions in this build-only workflow. Without an explicit `permissions` block, the checkout/install/lint steps inherit the repository default token scopes, which can be write-enabled.</comment>

<file context>
@@ -0,0 +1,20 @@
+concurrency:
+  group: lint-${{ github.ref }}
+  cancel-in-progress: true
+jobs:
+  lint:
+    runs-on: blacksmith-2vcpu-ubuntu-2204
</file context>
Fix with Cubic

push:
branches: [main]
pull_request:
concurrency:
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Add an explicit read-only permissions block for this checkout-and-test workflow. Otherwise it inherits repo/org default GITHUB_TOKEN permissions, which can be broader than necessary.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/test.yml, line 6:

<comment>Add an explicit read-only `permissions` block for this checkout-and-test workflow. Otherwise it inherits repo/org default `GITHUB_TOKEN` permissions, which can be broader than necessary.</comment>

<file context>
@@ -0,0 +1,20 @@
+  push:
+    branches: [main]
+  pull_request:
+concurrency:
+  group: test-${{ github.ref }}
+  cancel-in-progress: true
</file context>
Fix with Cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants