fix: improve update command validation and empty value handling

[Esubaalew]

This change fixes two update-command problems that could make the CLI behave in a confusing way.

The first issue was in templates update. If you ran the command without actually passing any fields to update, the CLI could still try to resolve or prompt for a template id before finally telling you there was nothing to change. That made the command feel backwards. It now checks for no_changes first and fails immediately instead of trying to fetch or pick a template unnecessarily.

The second issue was inconsistent handling of empty string values in update flows. broadcasts update was using truthy checks, which meant values like --text "" or --html "" could be treated like nothing was passed and silently dropped from the SDK payload. templates update also still had a few truthy checks in its downstream validation and warning paths, so empty string values could bypass conflict checks or skip warnings there too. Both commands now use explicit null/undefined checks so intentionally empty values are handled consistently and predictably.

I added regression coverage for both commands, including checks that templates update fails before opening the picker when there are no changes, and checks that empty string values still trigger the correct validation, warnings, and payload behavior.

---

Summary by cubic

Fixes confusing update flows in the CLI. templates update now validates and fails early without prompting for an id when there are no changes or conflicting options; both update commands treat empty strings and empty option values (including empty file paths) as intentional input.

• Bug Fixes
  • templates update: run no-change and conflict validation (react-email vs html/html-file, html+html-file, stdin conflicts) before resolving the id; returns specific errors without prompts.
  • Option handling: replace truthy checks with explicit null/undefined checks so --text "", --html "", --html-file "", --text-file "", --react-email "" are treated as provided; file inputs win with warnings; --var is respected when present.
  • Tests: add coverage for early failures, empty-string payloads, empty file/react-email inputs, and the new validation paths.

^{Written for commit d1075b4. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 4 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/commands/broadcasts/update.ts">

<violation number="1" location="src/commands/broadcasts/update.ts:71">
P2: Empty-string option values now pass the null-based no_changes guard but are ignored by downstream truthy checks (`opts.htmlFile`, `opts.textFile`, `opts.reactEmail`), potentially resulting in an empty update payload. This is inconsistent with the new empty-value handling and can cause confusing no-op updates.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}