Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/commands/emails/attachment.ts">
<violation number="1" location="src/commands/emails/attachment.ts:8">
P3: This command duplicates the inbound attachment command almost line-for-line. Consider extracting a shared helper for the attachment fetch/output formatting to avoid future drift when one side changes.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
joaopcm
approved these changes
Apr 9, 2026
Add list/get subcommands for outbound email attachments, mirroring the existing receiving (inbound) attachment commands. Move shared renderAttachmentsTable to emails/utils.ts for reuse across both.
Make receiving attachment command symmetrical with outbound: both emailId and attachmentId are now optional with interactive pickers. Add receivedAttachmentPickerConfig to receiving/utils.ts.
felipefreitag
force-pushed
the
feat-email-attachments
branch
from
d958946 to
7ecc75a
Compare
…tests outputError() writes to console.error, so the error test spies were capturing nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support outbound email attachments endpoints
Add interactivity to inbound emails attachments
Summary by cubic
Adds outbound email attachment list/get commands and makes inbound attachment retrieval interactive. Users can browse and download attachments via signed URLs.
New Features
resend emails attachments(list) andresend emails attachment(get). Prompts for email/attachment if omitted; list supports--limit,--after,--before; shows signeddownload_urlwith expiry.resend emails receiving attachmentnow accepts optional email and attachment IDs with interactive pickers and prints the same metadata as outbound.Refactors
renderAttachmentsTableand shared pickers tosrc/commands/emails/utils.ts; addedreceivedAttachmentPickerConfig; receiving list now uses the shared table.runGet/runList, registered new commands in theemailsindex, and added tests for outbound list/get.console.errorinstead ofconsole.log.Written for commit a9f7ed7. Summary will update on new commits.