fix: clean up telemetry temp files on flush failure#194
Merged
felipefreitag merged 2 commits intomainfrom Apr 14, 2026
Merged
Conversation
Member
Author
|
@cubic-dev-ai can you review? |
Contributor
@bukinoshita I have started the AI code review. It will take a few minutes to complete. |
Member
Author
|
@cursor fix conflicts |
|
The PR description was updated by cubic (automated summary), and the title is unchanged. No need to update the PR — the conflicts are resolved, tests pass, and the branch is pushed. Resolved the merge conflicts by rebasing   |
Wrap flushPayload() in try/finally so unlinkSync() runs regardless of whether the telemetry POST succeeds. Previously, failed flushes left orphaned resend-telemetry-*.json files in the system tmpdir. Resolves BU-619 Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
cursor
Bot
force-pushed
the
fix/telemetry-temp-file-leak-07f9
branch
from
ef3dd39 to
10e0d4d
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
felipefreitag
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Always delete telemetry temp files after any flush attempt to prevent leaks, even when the network request fails.
flushPayload()intry/finallyinflushFromFile()sounlinkSync()always runs.Written for commit ef3dd39. Summary will update on new commits.