fix: detach update notifier from command completion chain#197
Merged
felipefreitag merged 3 commits intomainfrom Apr 10, 2026
Merged
fix: detach update notifier from command completion chain#197felipefreitag merged 3 commits intomainfrom
felipefreitag merged 3 commits intomainfrom
Conversation
The checkForUpdates() promise was returned from the .then() callback, making it part of the parseAsync() completion flow. On stale/missing update cache with slow or unreachable GitHub, this could block process exit for up to 5 seconds after a successful command. Use void to fire-and-forget the update check instead of awaiting it. Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
Member
Author
|
@cubic-dev-ai can you review? |
Contributor
@bukinoshita I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
felipefreitag
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Prevents the CLI from hanging after successful commands by running the update check in the background. The notifier no longer blocks process exit, addressing BU-641.
program.parseAsync()chain by usingvoid checkForUpdates().catch(() => {}), so it’s fire-and-forget but still prints notices when available.Written for commit 7edb01f. Summary will update on new commits.