fix: preserve --var values as strings instead of auto-coercing to numbers#198
Merged
felipefreitag merged 4 commits intomainfrom Apr 10, 2026
Merged
fix: preserve --var values as strings instead of auto-coercing to numbers#198felipefreitag merged 4 commits intomainfrom
felipefreitag merged 4 commits intomainfrom
Conversation
…bers The send command's --var parser was converting any numeric-looking value to a JavaScript number, corrupting identifiers like OTPs with leading zeros, large IDs beyond MAX_SAFE_INTEGER, and scientific notation strings. Remove the Number() coercion and always pass --var values as strings, which is consistent with the template definition path where variable types are explicitly declared. Resolves BU-624 Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
Member
Author
|
@cubic-dev-ai can you review? |
Contributor
@bukinoshita I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
felipefreitag
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Preserves
--varvalues as strings in theemails sendcommand to stop numeric auto-coercion that corrupted IDs and OTPs. Fixes BU-624 and aligns CLI parsing with template variable types.--varvalues as strings; removed Number() coercion.Written for commit 7fb5822. Summary will update on new commits.