fix: install.sh

[felipefreitag]

No description provided.

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="install.sh">

<violation number="1" location="install.sh:257">
P2: `shell_bin_dir` escapes `$HOME`, which is required for quoted bash/zsh exports but breaks fish: `fish_add_path \$HOME/...` adds a literal `$HOME` path instead of the real home directory.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: shell_bin_dir escapes $HOME, which is required for quoted bash/zsh exports but breaks fish: fish_add_path \$HOME/... adds a literal $HOME path instead of the real home directory.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At install.sh, line 257:

<comment>`shell_bin_dir` escapes `$HOME`, which is required for quoted bash/zsh exports but breaks fish: `fish_add_path \$HOME/...` adds a literal `$HOME` path instead of the real home directory.</comment>

<file context>
@@ -242,12 +249,12 @@ case $shell_name in
     config="${XDG_CONFIG_HOME:-$HOME/.config}/fish/conf.d/resend.fish"
     mkdir -p "$(dirname "$config")"
-    shell_line="fish_add_path $(tildify "$bin_dir")"
+    shell_line="fish_add_path ${shell_bin_dir}"
     ;;
 esac
</file context>

Suggested change

	shell_line="fish_add_path ${shell_bin_dir}"
	shell_line="fish_add_path ${bin_dir}"