fix: reject empty and directory paths in --react-email#213
Merged
bukinoshita merged 4 commits intomainfrom Apr 9, 2026
Merged
Conversation
Empty --react-email values (e.g. --react-email "") resolve to CWD via
path.resolve(''), which always exists as a directory. This allows
unintended bundling and require() of arbitrary CWD modules with CLI
privileges.
Add validation in buildReactEmailHtml:
- Reject empty/whitespace-only paths before resolution
- Verify resolved path is a regular file, not a directory
Update the broadcasts update test to expect an error on empty
--react-email instead of treating it as valid input.
Fixes: BU-609
Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/commands/broadcasts/update.test.ts">
<violation number="1" location="tests/commands/broadcasts/update.test.ts:444">
P2: Spy on `console.error` here; `outputError()` never writes errors with `console.log`, so this test won't observe the failure it is asserting.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
felipefreitag
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Reject empty and directory paths for
--react-emailto close BU-609. This prevents bundling CWD modules and unintendedrequire()with CLI/API-key privileges.--react-emailbefore resolving the path.react_email_build_erroron empty input and avoid SDK calls.Written for commit 14b7420. Summary will update on new commits.