fix: forward pagination params in API key picker and list command#220
Merged
felipefreitag merged 4 commits intomainfrom Apr 14, 2026
Merged
fix: forward pagination params in API key picker and list command#220felipefreitag merged 4 commits intomainfrom
felipefreitag merged 4 commits intomainfrom
Conversation
The API key picker config was ignoring the limit/after pagination parameters passed by pickId() and hard-coding has_more to false. This prevented the interactive picker from showing keys beyond the first page, blocking revocation of older API keys. Changes: - apiKeyPickerConfig now forwards limit and after to resend.apiKeys.list() and preserves the SDK's has_more value - api-keys list command now accepts --limit, --after, --before flags with pagination hints, matching other paginated list commands - Added tests for picker config pagination forwarding - Updated list tests to cover pagination flag handling Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
Member
Author
|
@cubic-dev-ai can you review? |
Contributor
@bukinoshita I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
felipefreitag
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes pagination in the API key picker so you can revoke keys beyond the first page, and adds pagination flags to
api-keys listfor consistency and better navigation. Addresses BU-615.Bug Fixes
limitandaftertoresend.apiKeys.list()and preserveshas_more, enabling interactive deletion of older keys.New Features
api-keys listnow supports--limit,--after, and--before, forwards options to the SDK, and prints a pagination hint; default limit is 10.invalid_paginationif both--afterand--beforeare provided.Written for commit dfd9471. Summary will update on new commits.