chore: run react-email binary test only on relevant changes#276
Merged
felipefreitag merged 1 commit intomainfrom Apr 16, 2026
Merged
chore: run react-email binary test only on relevant changes#276felipefreitag merged 1 commit intomainfrom
felipefreitag merged 1 commit intomainfrom
Conversation
vcapretz
approved these changes
Apr 16, 2026
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/test-react-email-binary.yml">
<violation number="1" location=".github/workflows/test-react-email-binary.yml:6">
P2: The paths filter is too narrow for the react-email binary path; it misses runtime dependencies like `output.ts`, `spinner.ts`, and `tty.ts`, so relevant changes can skip this test.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
Change the workflow from running on every PR to running on manual dispatch or PRs that touch the react-email bundling layer, esbuild plugins, dependencies, or the workflow file itself.
felipefreitag
force-pushed
the
ffv/ci-react-email-binary-trigger
branch
from
3af284d to
4a67774
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Run the “Test
react-emailin binaries” workflow only on manual dispatch or PRs that touch thereact-emailbundling layer,esbuildplugins, dependencies, or the workflow file. This cuts unnecessary CI runs.Triggers limited to:
Written for commit 4a67774. Summary will update on new commits.