chore: setup ci#5
Merged
Merged
Conversation
vcapretz
reviewed
Mar 10, 2026
vcapretz
reviewed
Mar 10, 2026
vcapretz
reviewed
Mar 10, 2026
vcapretz
reviewed
Mar 10, 2026
vcapretz
reviewed
Mar 10, 2026
vcapretz
reviewed
Mar 10, 2026
vcapretz
approved these changes
Mar 10, 2026
dielduarte
added a commit
that referenced
this pull request
Jun 25, 2026
Felipe review (#5): migrateRawProfile cast oauth_grant entries with `as` and no validation, so a hand-edited or corrupted file would surface inconsistent state later. Require a string scope, and require token fields (when any are present) to form a complete, well-typed grant; throw CorruptedCredentialsError otherwise. Metadata-only secure-storage entries (scope only) remain valid.
dielduarte
added a commit
that referenced
this pull request
Jun 25, 2026
Refines #5: throwing CorruptedCredentialsError when an oauth_grant had partial or wrong-typed token fields made one bad profile unreadable for the whole file. Real files written by older clients can carry e.g. refresh_token_expires_at: null. Instead, drop invalid token fields during read so the profile degrades to a re-login while the rest of the file stays usable; the grant is still validated at point-of-use (resolveAuthentication / parseOAuthGrantBlob).
dielduarte
added a commit
that referenced
this pull request
Jul 3, 2026
Felipe review (#5): migrateRawProfile cast oauth_grant entries with `as` and no validation, so a hand-edited or corrupted file would surface inconsistent state later. Require a string scope, and require token fields (when any are present) to form a complete, well-typed grant; throw CorruptedCredentialsError otherwise. Metadata-only secure-storage entries (scope only) remain valid.
dielduarte
added a commit
that referenced
this pull request
Jul 3, 2026
Refines #5: throwing CorruptedCredentialsError when an oauth_grant had partial or wrong-typed token fields made one bad profile unreadable for the whole file. Real files written by older clients can carry e.g. refresh_token_expires_at: null. Instead, drop invalid token fields during read so the profile degrades to a re-login while the rest of the file stays usable; the grant is still validated at point-of-use (resolveAuthentication / parseOAuthGrantBlob).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.