feat: make windows workflow broader to pick issues

[felipefreitag]

No description provided.

[cubic-dev-ai]

2 issues found across 4 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="install.ps1">

<violation number="1" location="install.ps1:35">
P1: Error paths now return without a non-zero exit signal, so install failures can be reported as success to CI/scripts.</violation>
</file>

<file name=".github/workflows/test-install-windows.yml">

<violation number="1" location=".github/workflows/test-install-windows.yml:78">
P2: This assertion is ineffective: it runs in a new step/shell, so it cannot verify that the previous `Invoke-Expression` call did not terminate its host shell.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[mwoss]

Looks good! :D

[cubic-dev-ai]

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/test-install-windows.yml">

<violation number="1" location=".github/workflows/test-install-windows.yml:74">
P2: This check now passes on any installer failure, so an unrelated crash can be mistaken for the expected bogus-version error path.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: This check now passes on any installer failure, so an unrelated crash can be mistaken for the expected bogus-version error path.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/test-install-windows.yml, line 74:

<comment>This check now passes on any installer failure, so an unrelated crash can be mistaken for the expected bogus-version error path.</comment>

<file context>
@@ -62,22 +62,17 @@ jobs:
+
+      - name: Assert installer failed
+        run: |
+          if ('${{ steps.bogus.outcome }}' -ne 'failure') {
+            Write-Error "Expected installer to fail on bogus version"
             exit 1
</file context>