feat: contacts list segment

[kewynakshlley]

No description provided.

[cubic-dev-ai]

3 issues found across 3 files

Confidence score: 3/5

• There is a concrete regression risk in src/main/java/com/resend/services/contacts/Contacts.java: options is dereferenced without a null guard, which can cause a NullPointerException for callers passing null and change expected public API behavior.
• This lands at moderate risk (not a hard blocker) because the main issue is localized to null-handling in one area, but it is user-facing when triggered.
• src/test/java/com/resend/services/contacts/ContactsTest.java currently does not assert segmentId-over-audienceId precedence, so it may miss logic regressions even if behavior is wrong.
• Pay close attention to src/main/java/com/resend/services/contacts/Contacts.java, src/test/java/com/resend/services/contacts/ContactsTest.java - add null validation for options and strengthen precedence assertions in tests.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/main/java/com/resend/services/contacts/Contacts.java">

<violation number="1" location="src/main/java/com/resend/services/contacts/Contacts.java:163">
P2: Validate `options` before dereferencing it to avoid a NullPointerException when callers pass null.</violation>

<violation number="2" location="src/main/java/com/resend/services/contacts/Contacts.java:189">
P2: Guard against null `options` before calling `resolvedSegmentId()` to keep public API behavior consistent and avoid NPEs.</violation>
</file>

<file name="src/test/java/com/resend/services/contacts/ContactsTest.java">

<violation number="1" location="src/test/java/com/resend/services/contacts/ContactsTest.java:71">
P3: This test never verifies that segmentId takes precedence over audienceId; it only checks the mocked response size, so it would pass even if precedence logic is wrong.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}