feat: support logs endpoints#88
Merged
kewynakshlley merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 8 files
Confidence score: 3/5
- There is meaningful merge risk because
src/main/java/com/resend/services/logs/Logs.javaadds Logs SDK operations without explicit confirmation that existing production API keys have Logs-read permission, which could cause authorization failures for current users. - Test coverage confidence is limited:
src/test/java/com/resend/services/logs/LogsTest.javamocks theLogsservice itself, so tests may pass even if endpoint integration behavior is incorrect. - Given both issues are severity 7/10 with high confidence, this looks mergeable only with caution until permission compatibility and real behavior validation are confirmed.
- Pay close attention to
src/main/java/com/resend/services/logs/Logs.java,src/test/java/com/resend/services/logs/LogsTest.java- API key permission compatibility and endpoint-level test validity are the main regression risks.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/main/java/com/resend/services/logs/Logs.java">
<violation number="1" location="src/main/java/com/resend/services/logs/Logs.java:1">
P1: Custom agent: **API Key Permission Check SDK Methods**
New Logs SDK operations were added without an explicit confirmation that existing production API keys have Logs-read permission, which violates the API key permission check rule and can cause runtime authorization failures after release.</violation>
</file>
<file name="src/test/java/com/resend/services/logs/LogsTest.java">
<violation number="1" location="src/test/java/com/resend/services/logs/LogsTest.java:25">
P1: These tests mock the `Logs` service itself, so they do not validate real endpoint behavior and can pass even if `Logs` implementation is broken.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| @BeforeEach | ||
| public void setUp() { | ||
| MockitoAnnotations.openMocks(this); | ||
| logs = mock(Logs.class); |
Contributor
There was a problem hiding this comment.
P1: These tests mock the Logs service itself, so they do not validate real endpoint behavior and can pass even if Logs implementation is broken.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/test/java/com/resend/services/logs/LogsTest.java, line 25:
<comment>These tests mock the `Logs` service itself, so they do not validate real endpoint behavior and can pass even if `Logs` implementation is broken.</comment>
<file context>
@@ -0,0 +1,102 @@
+ @BeforeEach
+ public void setUp() {
+ MockitoAnnotations.openMocks(this);
+ logs = mock(Logs.class);
+ }
+
</file context>
felipefreitag
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.