-
Notifications
You must be signed in to change notification settings - Fork 16
feat: Inline attachment support #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| import os | ||
|
|
||
| import resend | ||
|
|
||
| if not os.environ["RESEND_API_KEY"]: | ||
| raise EnvironmentError("RESEND_API_KEY is missing") | ||
|
|
||
| f: bytes = open( | ||
| os.path.join(os.path.dirname(__file__), "../resources/resend-wordmark-black.png"), | ||
| "rb", | ||
| ).read() | ||
|
|
||
| # Send email with local inline attachment | ||
| local_attachment: resend.Attachment = { | ||
| "filename": "resend-wordmark-black.png", | ||
| "content": list(f), | ||
| "content_type": "image/png", | ||
| # This is the content ID that will be used in the HTML to reference the image | ||
| "inline_content_id": "my-test-image", | ||
| } | ||
|
|
||
| local_params: resend.Emails.SendParams = { | ||
| "from": "onboarding@resend.dev", | ||
| "to": ["delivered@resend.dev"], | ||
| "subject": "Local inline attachment test from Resend's python SDK", | ||
| "html": '<p>This email contains a local inline attachment: <img width=100 height=40 src="cid:my-test-image" /></p>', | ||
| "attachments": [local_attachment], | ||
| } | ||
|
|
||
| local_email: resend.Email = resend.Emails.send(local_params) | ||
| print("Sent email with local inline attachment") | ||
| print(local_email) | ||
|
|
||
| # Send email with remote inline attachment | ||
| remote_attachment: resend.RemoteAttachment = { | ||
| "filename": "remote-resend-wordmark-black.png", | ||
| "path": "https://resend.com/static/brand/resend-wordmark-black.png", | ||
| "inline_content_id": "my-test-image", | ||
| } | ||
|
|
||
| remote_params: resend.Emails.SendParams = { | ||
| "from": "onboarding@resend.dev", | ||
| "to": ["delivered@resend.dev"], | ||
| "subject": "Remote inline attachment test from Resend's python SDK", | ||
| "html": '<p>This email contains a remote inline attachment: <img width=100 height=40 src="cid:my-test-image" /></p>', | ||
| "attachments": [remote_attachment], | ||
| } | ||
|
|
||
| remote_email: resend.Email = resend.Emails.send(remote_params) | ||
| print("Sent email with remote inline attachment") | ||
| print(remote_email) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the "content" field of the normal Attachment class was required (however remote attachments do not need to set
content), and I couldn't make itNotRequiredwithout introducing a breaking change. So I created this new typeRemoteAttachmentthat users can use when using remote attachments.