Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 10 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="tests/attachments_test.py">
<violation number="1" location="tests/attachments_test.py:68">
Rule violated: **No `should` in tests**
Rename this test to avoid using “should” in its name per the “No should in tests” guideline; use a direct, declarative description instead.</violation>
</file>
<file name="examples/receiving_email.py">
<violation number="1" location="examples/receiving_email.py:8">
Accessing RESEND_API_KEY via os.environ[...] raises KeyError when the variable is unset, so the intended EnvironmentError is never triggered. Use os.environ.get to avoid the KeyError.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
lucasfcosta
approved these changes
Oct 25, 2025
Contributor
lucasfcosta
left a comment
lucasfcosta
left a comment
There was a problem hiding this comment.
LGTM! Seems like we have a few redundant comments but nothing blocking.
examples/receiving_email.py
Outdated
Comment on lines
27
to
33
| print(f"HTML: {html_content[:100]}...") # Show first 100 chars | ||
| else: | ||
| print("HTML: None") | ||
|
|
||
| text_content = received_email.get("text") | ||
| if text_content: | ||
| print(f"Text: {text_content[:100]}...") # Show first 100 chars |
Contributor
There was a problem hiding this comment.
Nit: can we cleanup the comments a bit?
| """ | ||
|
|
||
|
|
||
| # Uses functional typed dict syntax here in order to support "from" reserved keyword |
Contributor
There was a problem hiding this comment.
Suggested change
| # Uses functional typed dict syntax here in order to support "from" reserved keyword |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReceivedEmailAttachmentDetails
Summary by cubic
Adds inbound email receiving to the SDK with methods to fetch received emails and their attachments, plus typed responses. Supports pagination and exposes receiving namespaces under Emails and Attachments.
New Features
Types